Messages posted by: apl

You need a most recently backup of your database B-),
if you haven't any, good luck and try to recover your database:

If you use derby all files under ... see your env.properties
or
if you use mysql, the mysql database or try to recover the mysql db this would be a MySQL topic...

Arne

Thats where further development of mango will happen ...

Arne

Sorry, the sf site is in english, trac for bug reporting as well, mailing list (devel) - where is your problem (by the way I am german ;-))

Arne

Search for ScadaBr

Arne

I thougth that the the whole thing is there, to add new DataPoints to RT if the RT is polling the dataPoints.
with the lock only one Thread can access the add/Remove or pointList.

I have a lock for the addList (the addList) one for remove and one for the pointList.
so adding will lock only the addList ...
If I copy over I must lock all.

src is here (modified)
https://scadabr.svn.sourceforge.net/svnroot/scadabr/trunk/scadabr/scadabr/src/main/java/com/serotonin/mango/rt/dataSource/DataSourceRT.java

in DataSourceRT.addDataPoint(...)
pointListChangeLock is used to synchronize access to addedChangedPoints and removedPoints.

in PollingDataSource.scheduleTimeout you synchronize also with pointListChangeLock...

This makes the whole thing useless, you wont have separate access to add/Remove points.

@2 You right, I was puzzled by the usage of Boolean ;-)

It looks that in
package com.serotonin.mango.db.upgrade
class Upgrade0_9_2
line 50
the 2. arg should be the dataTypeId and not dataSourceTypeId.

@matthew

Why not use:

org.springframework.jdbc.core.JdbcTemplate tmpl = new JdbcTemplate();
tmpl.setMaxRows(limit);

in seroUtils.jar?

I am delighted

Here a "bug" for you. Please have a look at pointListChangeLock in DataSourceRT and PollingDataSourceRT.

1. the lock filed is not final.
2. Its a commonly known static Object Boolean.TRUE
3. the same lock will be used for writing the "cache" and working with the list, which made the lock useless in the first place.
this is fixed in ScadaBR

Arne.

P.S. if you interested in further bugs, if I come along, please let me know.

The class DaoUtils is in seroUtils.jar - so that is closed source ;-) maybe you can write that whole piece (com.serotonin.db.*) new and give the code to ScadaBR ...

I honesty doubt that there will be any future development of Mango (M2M2 yes, but that is closed source at all)

Arne

Im missing a way to JSON serialize an enum by annotation - can you provide the sources to implement this?
Or should I take the approach from my last mail?

So for ScadaBR I will have to throw out all references to seroUtil in order to get a full Open Source?

So, can I
[ ] get the needed sources
or
[ ] decompile the needed classes it for ScadaBR?

and

[ ] put them in a different packages?

OR have a double license GPL and closed source licenses for serotonin only? (this can include any code commited to the GPL version is also in the closed source as well)?

Arne

mlohbihler wrote:Modbus4J *is* open source, as all of the sources for *Modbus4J* are provided. As i said, seroUtils.jar is not open source, not for any matter of secrecy, but only because there are parts of it that users will most certainly ask about that we are not prepared to support. It is, of course, Java technology, and as such resourceful users will - i'm certain - find ways to debug their code without Serotonin having to take on supporting yet another open source project. Again, if this does not suit your sense of entitlement, you have alternatives.

Can I take this, that I can reengineer the needed sorces for mango M2M (1.12.4) for further development?
Or under which license is seroUtils.jar?

the code under trunk/scadabr/scadabr is a mavenized mango 1.12.4 (no source for 1.12.5)
the missing jars for maven are under missing* run the install script to install them (*NIX)

I plan to clear out the properitary stuff under branches/arnep-* this will take a while.

For further questions ask the devellist/trac there

Arne